Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Search links rendered rich attributes break when value contains space #870

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

psrok1
Copy link
Member

@psrok1 psrok1 commented Jul 31, 2023

…space

Your checklist for this pull request

  • I've read the contributing guideline.
  • I've tested my changes by building and running the project, and testing changed functionality (if applicable)
  • I've added automated tests for my change (if applicable, optional)
  • I've updated documentation to reflect my change (if applicable)

What is the current/new behaviour?

Yet another encoding maze:

Markdown doesn't render links that contain space [name](/q=attr:"my value")

It means we should use URI-encoding for these links, but React-Router's Link expects non-encoded part URI, so we need to decode it before passing to Link

@psrok1 psrok1 force-pushed the fix/rich-attribute-link-spaces branch from 1df7ae5 to c85e61d Compare July 31, 2023 11:50
@psrok1 psrok1 merged commit 2d10dca into master Jul 31, 2023
12 checks passed
@psrok1 psrok1 deleted the fix/rich-attribute-link-spaces branch July 31, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant